Fix broken json schema option #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 79804a0 in 35 seconds. Click for details.
- Reviewed
28lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/main/java/nl/dannyj/mistral/models/completion/tool/JsonSchema.java:64
- Draft comment:
Using @JsonRawValue here is a valid fix to emit the JSON schema as raw JSON. Ensure that the content of 'schema' is always valid JSON to avoid runtime serialization issues. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_yTwGVObjokAgODkg
You can customize 
Owner
|
Thank you for submitting this PR! This was indeed an oversight introduced in version 2.0 that I didn't catch during testing. Merging this now. I'll publish a new release in the next few days. Thanks again for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mistral expects a json object for the schema field but was provided a string encoding the json object.
Fixed by telling jackson to treat the string as raw json
Important
Fixes JSON schema handling in
JsonSchemaby adding@JsonRawValueto treatschemaas raw JSON.JsonSchemaclass by adding@JsonRawValuetoschemafield.schemais treated as raw JSON, aligning with Mistral's expectations.@JsonRawValuetoschemafield inJsonSchemaclass.This description was created by
for 79804a0. You can customize this summary. It will automatically update as commits are pushed.